Refactor helpers/expandr.py
#925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add types and basic refactoring of `helpers/expandr.py`. Reformat position mappings from csv to json for easier reading at import time. Use CantusDB `genres` endpoint (rather than html parsing) to import genre information.
`test_import_all_data` imports all manuscripts in the test database and then does nothing with them. This takes a long time when running tests and is not very helpful. Since a refactoring of the entire import/indexing process is incoming, this test can be temporarily removed.
ahankinson
reviewed
Dec 17, 2024
ahankinson
reviewed
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #900.
The most significant change in this PR to
expandr.pyis the use of the/genresendpoint on CantusDB to get genre code -> description mappings, rather than parsing CantusDB's html.Removes
test_import_all_data, which previously called the manuscript import command but then did not do any testing with the results (in other words, it tested that the command ran without any python error). Since we are in the midst of a larger refactor of data import, I think we can safely get rid of this test for the time being.